Re: [PATCH v2] video: mxsfb: Make sure axi clock is enabled when accessing registers

[Tomi Valkeinen]

On 11/03/15 05:03, Liu Ying wrote:

>> Why do you check for host->enabled here, but not elsewhere?
> 
> We need this check here to make sure the axi clock reference count is no greater
> than 1.  Looking at the context of mxsfb_set_par(), mxsfb_restore_mode() and

Why is that? The clock framework handles ref counting for you. All the
driver needs to take care of is to call as many times disable as it
calls enable.

 Tomi

Attachment: signature.asc
Description: OpenPGP digital signature