Re: [PATCH 3/3] Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404.
From: Greg KH
Date: Fri Mar 20 2015 - 10:42:20 EST
On Wed, Feb 25, 2015 at 06:34:18PM +0200, Ameen Ali wrote:
> else if at line 406 has the same condition as the else if at line 404.
> i chosed 0x5 because it's half 0xb (just a rate controller)
> Signed-off-by : Ameen Ali <Ameenali023@xxxxxxxxx>
> ---
> drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
How do you know this is correct?
Also, we need a blank line before the signed-off-by line and your
subject should give us a chance to know what driver is being changed, as
well as the subsystem.
Also, where are patches 1/3 and 2/3?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/