Re: smp_call_function_single lockups

From: Mike Galbraith
Date: Fri Mar 20 2015 - 13:16:36 EST


On Fri, 2015-03-20 at 09:26 -0700, Linus Torvalds wrote:
> On Fri, Mar 20, 2015 at 3:15 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> >
> > Linus, any plans for this patch? I think it does solve a fair few issues
> > the current code has.
>
> So I didn't really have any plans. I think it's a good patch, and it
> might even fix a bug and improve code generation, but it didn't fix
> the lockup problem, so..
>
> > do you want me to route it through tip (and write a changelog while I'm
> > at it) or will you be taking it yourself?
>
> If you think it's worth committing, then go ahead. Add my signed-off,
> although I have to note that I didn't do a lot of testing of that
> patch (I think it was compile-tested when I sent it out, and then I
> ended up running it for a while, and obviously it got *some* testing
> by the person who saw the lockup that just showed that it didn't fix
> the problem ;(

I carried it for a while on boxen big and small, so it got some burn-in.

-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/