Re: [PATCH 1/4] iio: adc: add support for Berlin

From: Lars-Peter Clausen
Date: Fri Mar 20 2015 - 14:48:27 EST


On 03/20/2015 06:43 PM, Peter Meerwald wrote:
Hello Antoine,

This patch adds the support of the Berlin ADC, available on Berlin SoCs.
This ADC has 8 channels available, with one connected to a temperature
sensor.

The particularity here, is that the temperature sensor connected to the
ADC has its own registers, and both the ADC and the temperature sensor
must be configured when using it.

some quick comments inline below;
sometimes this refers to berlin, sometimes to berlin2?

probably these regmap_read() / _write() pairs could be MACRO()'d away
somehow

There is regmap_update_bits(), which does the read-modify-update cycle.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/