Re: [PATCH v8 tip 5/9] tracing: allow BPF programs to call bpf_trace_printk()
From: Alexei Starovoitov
Date: Fri Mar 20 2015 - 17:44:31 EST
On 3/20/15 2:22 PM, Steven Rostedt wrote:
+/* limited trace_printk()
+ * only %d %u %x %ld %lu %lx %lld %llu %llx %p conversion specifiers allowed
+ */
Ah! Again, don't contaminate the rest of the kernel with net comment
styles! :-)
ok :)
+ } else if (fmt[i] == 'p') {
+ mod[fmt_cnt]++;
+ i++;
+ if (!isspace(fmt[i]) && fmt[i] != 0)
I wonder if we should allow punctuation here too? None alpha-numeric
characters?
yes. just checked all of ispunct characters after %p.
All should be fine.
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/