Re: [PATCH v1 03/11] stm class: dummy_stm: Add dummy driver for testing stm class

[Paul Bolle]

All I spotted is the same two nits as in 04/11.

On Fri, 2015-03-20 at 19:29 +0200, Alexander Shishkin wrote:

> --- a/drivers/hwtracing/stm/Kconfig
> +++ b/drivers/hwtracing/stm/Kconfig

> +config STM_DUMMY
> +        tristate "Dummy STM driver"

Tab instead of eight spaces, please.

> +	default N

You meant
	default n

as n is a magic symbol. But n is the default anyway, so I think you
might as well drop this line.

> +	help
> +	  This is a simple dummy device that pretends to be an stm device
> +	  and discards your data. Use for stm class testing.
> +
> +	  If you don't know what this is, say N.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/