Re: [PATCH 33/35 linux-next] mmc: constify of_device_id array

[Fabian Frederick]

> On 20 March 2015 at 09:56 Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
>
>
> On 17 March 2015 at 10:49, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> > On 16 March 2015 at 20:59, Fabian Frederick <fabf@xxxxxxxxx> wrote:
> >> of_device_id is always used as const.
> >> (See driver.of_match_table and open firmware functions)
> >>
> >> Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>
> >
> > Acked-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
>
> I realized that you might wanted me to pick this up and queue it
> through my mmc tree? Just tell me if that's what you want.
>
> Kind regards
> Uffe

Hi Ulf,

    Yes of course :) (it has not been added to linux-next yet).

Thanks,
Fabian
>
> >
> >> ---
> >> drivers/mmc/host/mmc_spi.c Â| 2 +-
> >>Â drivers/mmc/host/wmt-sdmmc.c | 2 +-
> >>Â 2 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
> >> index e4a0754..ae19d83 100644
> >> --- a/drivers/mmc/host/mmc_spi.c
> >> +++ b/drivers/mmc/host/mmc_spi.c
> >> @@ -1507,7 +1507,7 @@ static int mmc_spi_remove(struct spi_device *spi)
> >>Â Â Â Â Âreturn 0;
> >>Â }
> >>
> >> -static struct of_device_id mmc_spi_of_match_table[] = {
> >> +static const struct of_device_id mmc_spi_of_match_table[] = {
> >>Â Â Â Â Â{ .compatible = "mmc-spi-slot", },
> >>Â Â Â Â Â{},
> >>Â };
> >> diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c
> >> index dd2e1aa..5af0055 100644
> >> --- a/drivers/mmc/host/wmt-sdmmc.c
> >> +++ b/drivers/mmc/host/wmt-sdmmc.c
> >> @@ -744,7 +744,7 @@ static struct wmt_mci_caps wm8505_caps = {
> >>Â Â Â Â Â.max_blk_size = 2048,
> >>Â };
> >>
> >> -static struct of_device_id wmt_mci_dt_ids[] = {
> >> +static const struct of_device_id wmt_mci_dt_ids[] = {
> >>Â Â Â Â Â{ .compatible = "wm,wm8505-sdhc", .data = &wm8505_caps },
> >>Â Â Â Â Â{ /* Sentinel */ },
> >>Â };
> >> --
> >> 2.1.0
> >>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/