[tip:perf/core] perf tools: Fix the bash completion for listing events of perf subcommand record|stat|top -e

From: tip-bot for Yunlong Song
Date: Sun Mar 22 2015 - 06:10:31 EST

Commit-ID: bc81fad125dba7da33dbeac4c10d9c84614eb3ab
Gitweb: http://git.kernel.org/tip/bc81fad125dba7da33dbeac4c10d9c84614eb3ab
Author: Yunlong Song <yunlong.song@xxxxxxxxxx>
AuthorDate: Wed, 18 Mar 2015 21:35:49 +0800
Committer: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
CommitDate: Thu, 19 Mar 2015 13:49:37 -0300

perf tools: Fix the bash completion for listing events of perf subcommand record|stat|top -e

The bash completion does not support listing events for 'perf kvm|kmem|
mem|lock|sched record|stat|top -e <TAB>', where 'kvm|kmem|mem|lock|sched'
are all subcommands of perf.


Before this patch:

$ perf kvm record -e <TAB>

As shown above, the events of record does not come out.

After this patch:

$ perf kvm record -e <TAB>
alignment-faults cpu/instructions/
L1-dcache-prefetch-misses node-prefetches
branch-instructions cpu/mem-loads/
L1-dcache-store-misses node-prefetch-misses
branch-load-misses cpu-migrations
L1-dcache-stores node-store-misses
branch-loads dTLB-load-misses
L1-icache-load-misses node-stores

As shown above, the events of record can come out now.

Signed-off-by: Yunlong Song <yunlong.song@xxxxxxxxxx>
Tested-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
Cc: Paul Mackerras <paulus@xxxxxxxxx>
Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
Cc: Wang Nan <wangnan0@xxxxxxxxxx>
Link: http://lkml.kernel.org/r/1426685758-25488-5-git-send-email-yunlong.song@xxxxxxxxxx
Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
tools/perf/perf-completion.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh
index 01ce841..4b58ac2 100644
--- a/tools/perf/perf-completion.sh
+++ b/tools/perf/perf-completion.sh
@@ -138,7 +138,7 @@ __perf_main ()
__perfcomp "$cmds" "$cur"
# List possible events for -e option
- elif [[ $prev == "-e" && "${words[1]}" == @(record|stat|top) ]]; then
+ elif [[ $prev == "-e" && $prev_skip_opts == @(record|stat|top) ]]; then
evts=$($cmd list --raw-dump)
__perfcomp_colon "$evts" "$cur"
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/