Re: [PATCH v1 07/11] intel_th: Add Global Trace Hub driver

[Alexander Shishkin]

On 20 March 2015 at 19:59, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Fri, 2015-03-20 at 19:29 +0200, Alexander Shishkin wrote:
>> Global Trace Hub (GTH) is the central component of Intel TH architecture;
>> it carries out switching between the trace sources and trace outputs, can
>> enable/disable tracing, perform STP encoding, internal buffering, control
>> backpressure from outputs to sources and so on.
>
> trivia:

Thank you for reviewing!

>> +     signed char             master[TH_CONFIGURABLE_MASTERS + 1];
>
> why signed?

I'm using -1 to mean "disabled" (0 being a valid port number).

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/