Re: [PATCH 08/18] net: dsa: mv88e6xxx: Add Hardware bridging support

[Guenter Roeck]

On 03/22/2015 01:06 PM, Andrew Lunn wrote:
> Hi Guenter
>
> > +static int _mv88e6xxx_atu_cmd(struct dsa_switch *ds, int fid, u16 cmd)
> > +{
> > +	int ret;
> > +
> > +	ret = _mv88e6xxx_reg_write(ds, REG_GLOBAL, 0x01, fid);
> > +	if (ret < 0)
> > +		return ret;
>
> Please could you check this. I think register 0x01 here is wrong. I
> think you want 0x0b, the ATU Operations register?
The ATU operation is initiated below (and does write to register 0x0b).
Register 0x01 is FID[11..0] for ATU, which is what we want to write here.

Guenter

> Thanks
> 	Andrew
>
> > +
> > +	ret = _mv88e6xxx_reg_write(ds, REG_GLOBAL, 0x0b, cmd);
> > +	if (ret < 0)
> > +		return ret;
> > +
> > +	return _mv88e6xxx_atu_wait(ds);
> > +}
> > +

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/