Re: [PATCH] perf tools: Remove (null) value of "Sort order" for perf mem report

[Yunlong Song]

On 2015/3/23 8:44, Namhyung Kim wrote:
> Hi Yunlong,
> 
> On Thu, Mar 19, 2015 at 09:58:32PM +0800, Yunlong Song wrote:
>> When '--sort' is not set, 'perf mem report" will print a null pointer as
>> the output value of sort order, so fix it.
>>
>> Example:
>>
>> Before this patch:
>>
>>  $ perf mem report
>>  # To display the perf.data header info, please use --header/--header-only options.
>>  #
>>  # Samples: 18  of event 'cpu/mem-loads/pp'
>>  # Total weight : 188
>>  # Sort order   : (null)
>>  #
>>  ...
>>
>> After this patch:
>>
>>  $ perf mem report
>>  # To display the perf.data header info, please use --header/--header-only options.
>>  #
>>  # Samples: 18  of event 'cpu/mem-loads/pp'
>>  # Total weight : 188
>>  #
>>  ...
> 
> I think it'd be better to show default sort order in this case.
> 
> 

Agree, I have changed that into a default sort order in PATCH v2, thanks.

-- 
Thanks,
Yunlong Song

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/