Re: [PATCH 10/11] x86/xip: resolve alternative instructions at build

From: Borislav Petkov
Date: Mon Mar 23 2015 - 04:40:12 EST


On Mon, Mar 23, 2015 at 09:33:02AM +0100, Borislav Petkov wrote:
> is this it? To save some memory? Probably embedded, maybe some light
> bulb running linux... Yuck.

Oh, one more thing: AFAICT, you're adding the whole XIP functionality
with a bunch of ifdeffery in the main code paths. It might be better to
extract and put all that code in arch/x86/xip/, away from the generic
paths. I'm thinking there will be more XIP code coming besides this
patchset so designing it clean from the get-go should pay out handsomely
later.

Hmm.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/