Re: [PATCH 14/31] perf build: Rename PERF-FEATURES into FEATURE-DUMP

[Jiri Olsa]

On Sun, Mar 22, 2015 at 11:19:33AM +0100, Ingo Molnar wrote:
> 
> * Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
> 
> > From: Jiri Olsa <jolsa@xxxxxxxxxx>
> > 
> > Preparing for feature checks separation, moving related stuff under
> > 'FEATURE*' namespace.
> > 
> > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> > Cc: Corey Ashford <cjashfor@xxxxxxxxxxxxxxxxxx>
> > Cc: David Ahern <david.ahern@xxxxxxxxxx>
> > Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> > Cc: Paul Mackerras <paulus@xxxxxxxxx>
> > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > Link: http://lkml.kernel.org/n/tip-v9oo22ra70rrk1dy495a7bjc@xxxxxxxxxxxxxx
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> 
> So I think the various capital letter files in $(cwd) are highly 
> suboptimal:
> 
>  FEATURE-DUMP
>  PERF-CFLAGS
>  PERF-VERSION-FILE

we no longer have the PERF-CFLAGS file:
  db8486626246 perf build: Remove PERF-CFLAGS file

forgot to update the .gitignore file, will do

> I think we should standardize on something less pushy (no shouting), 
> plus more standardized, more logical, more coherent names, i.e. 
> something like:
> 
>    .build.features.cache
>    .build.cflags
>    .build.version
> 
> ?
> 
> .build.features.* would be reserved to the generic feature detection 
> machinery.
> 
> .build.cflags and .build.version could be used by the perf build - 
> hopefully exported to tools/build/ as well in the future! :-)

ok, noted ;-)

> That way the .gitignore could just ignore .build.* and we'd not have 
> to update it much.

agreed

> 
> Btw., another small nit: could we please do a (git-)rename of 
> tools/build/feature/ to tools/build/features/?
> 
> Plural is what is used typically for generic frameworks that deal with 
> a set of items (features in this case) - for example we have 
> tools/tests/, and tools/perf/scripts/, not tools/test/ and 
> tools/perf/script/.

ok, I'll try to address all this in the next build update

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/