Re: [PATCH] net: tcp6: fix double call of tcp_v6_fill_cb()

[Eric Dumazet]

On Mon, 2015-03-23 at 13:38 +0300, Alexey Kodanev wrote:
\
> @@ -1538,7 +1525,7 @@ do_time_wait:
>  					    &ipv6_hdr(skb)->saddr, th->source,
>  					    &ipv6_hdr(skb)->daddr,
>  					    ntohs(th->dest), tcp_v6_iif(skb));
> -		if (sk2 != NULL) {
> +		if (sk2) {
>  			struct inet_timewait_sock *tw = inet_twsk(sk);
>  			inet_twsk_deschedule(tw, &tcp_death_row);
>  			inet_twsk_put(tw);

And please refrain adding such cleanup changes in a bug fix.

Thanks !


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/