Re: [RFC PATCH 2/7] printk: Simple implementation for NMI backtracing

From: Daniel Thompson
Date: Mon Mar 23 2015 - 10:52:05 EST


On 19/03/15 19:01, Steven Rostedt wrote:
On Thu, 19 Mar 2015 18:48:10 +0000
Daniel Thompson <daniel.thompson@xxxxxxxxxx> wrote:
\
The barrier was not intended to have anything to do with put_cpu()
either though since the barrier was added before put_cpu() arrived:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=554ec063982752e9a569ab9189eeffa3d96731b2

There's nothing in the commit comment explaining the barrier and I
really can't see what it is for.


Looks like it wasn't needed then either.

Agreed. I'll respin the patchset with the barrier removed.


Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/