Re: [PATCH] Net: ethernet: rocker: fixed a space coding style issue

[David Miller]

From: Jiri Pirko <jiri@xxxxxxxxxxx>
Date: Mon, 23 Mar 2015 14:18:39 +0100

> Sat, Mar 21, 2015 at 07:02:40PM CET, andreimaresu@xxxxxxxxx wrote:
>>Fixed a space coding style issue found by checkpatch.pl in rocker.c
>>
>>Signed-off-by: Andrei Maresu <andreimaresu@xxxxxxxxx>
>>---
>> drivers/net/ethernet/rocker/rocker.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c
>>index 9fb6948..d364b12 100644
>>--- a/drivers/net/ethernet/rocker/rocker.c
>>+++ b/drivers/net/ethernet/rocker/rocker.c
>>@@ -812,7 +812,7 @@ static void *rocker_desc_cookie_ptr_get(struct rocker_desc_info *desc_info)
>> static void rocker_desc_cookie_ptr_set(struct rocker_desc_info *desc_info,
>> 				       void *ptr)
>> {
>>-	desc_info->desc->cookie = (uintptr_t) ptr;
>>+	desc_info->desc->cookie = (uintptr_t)ptr;
> 
> Checkpatch does not mark this as an error, not even as a warning:
> "CHECK: No space is necessary after a cast". I personally like the
> notation with space better.

Me too, I'm not applying this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/