Re: [PATCH] staging: unisys: handle major number properly

[Greg Kroah-Hartman]

On Tue, Mar 17, 2015 at 08:31:24PM +0530, Sudip Mukherjee wrote:
> fixed the handling of dev_t and the major number.
> now the major and minor number is passed to the init function.
> similarly in the cleanup function dev_t is passed to unregister it.
> 
> Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
> ---
>  drivers/staging/unisys/visorchipset/file.c             | 18 ++++++++----------
>  drivers/staging/unisys/visorchipset/file.h             |  4 ++--
>  .../staging/unisys/visorchipset/visorchipset_main.c    | 10 +++-------
>  3 files changed, 13 insertions(+), 19 deletions(-)

This doesn't apply anymore, due to other changes recently to this
driver.

But even if it did, I don't think it is correct.  I really don't
understand what you are trying to do here.  I think you just merged two
different major numbers togther, which isn't good at all.  But if you
didn't, then why is this patch doing different things to different files
(hint, only do one thing per file.)

Also, why does the driver have multiple major numbers?  Isn't a single
major good enough?  How many does it need?  For what does it use them
for?

Totally confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/