Re: [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static?
From: Bjorn Helgaas
Date: Mon Mar 23 2015 - 22:30:23 EST
On Mon, Mar 23, 2015 at 8:15 PM, Yijing Wang <wangyijing@xxxxxxxxxx> wrote:
>>> sparse warnings: (new ones prefixed by >>)
>>>
>>>>> drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static?
>>>
>>> Please review and possibly fold the followup patch.
>>
>> It does look like pci_find_host_bridge() is only used inside
>> drivers/pci/host-bridge.c and could be static. Given that it's only
>> used there, it doesn't even need to be renamed, so maybe you could
>> even just drop the rename patch, too.
>
> OK.
>
> Hi Bjorn, because this series involved lots platforms and host bridge chips, and this version takes a lot of changes.
> So I didn't take lot of time to cross build this series in all the platforms in my local. I hope you could see the changes
> first, and I will refresh and fix the details soon.
I just put them on a branch for build testing. I will review them
more closely when the build problems are resolved.
FYI, I'll be on vacation from Mar 25 - Apr 2, so I won't be able to do
much then.
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/