Re: [PATCH 3/3] block: loop: use vfs ITER_BVEC to read/write backing file

[Ming Lei]

On Tue, Mar 24, 2015 at 6:31 PM, Christoph Hellwig <hch@xxxxxx> wrote:
> On Sun, Mar 22, 2015 at 04:14:54PM +0800, Ming Lei wrote:
>> Now loop code gets simplified a lot, and becomes more clean.
>>
>> Also one extra page copy is avoided for READ in case of none
>> transfer.
>
> I really don't like the mess with the wrappers to pretent that read/write
> work the same,

Could you comment on code about the mess?

Actually this patch tried to move common things between read/write
out of read() and write() compared before.

> and the ibvec_rw_data structure doesn't exactly help
> readability either.

This can be removed if you think lots of parameters are better.

Thanks,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/