Re: [PATCH v4 1/4] staging: unisys: remove unneeded comparison

From: Dan Carpenter
Date: Tue Mar 24 2015 - 08:30:39 EST


On Tue, Mar 24, 2015 at 05:47:34PM +0530, Sudip Mukherjee wrote:
> visorchipset_file_cleanup() is called from visorchipset_exit() which
> is the module_exit function and this function is executing means
> module_init succeeded, so registered will always be true at this time.
> and majordev has also been initialized in the init function. hence
> these comparisons will always be true.
>
> Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>

This is a partial patch. The "one thing per patch" means don't do half
a thing per patch.

We now set "registered" but there are no users.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/