[PATCH 1/9] tools lib traceevent: Handle NULL comm name

[Steven Rostedt]

From: Josef Bacik <jbacik@xxxxxx>

It is possible that a pid has no associated comm attached to it, although it
can still be passed to pevent_register_comm(). But if comm is NULL, it will
cause strdup() to segfault. To prevent this from happening, if comm is NULL
use the default "<...>" name for the pid.

Link: http://lkml.kernel.org/p/1403799732-30308-1-git-send-email-jbacik@xxxxxx
Signed-off-by: Josef Bacik <jbacik@xxxxxx>
Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
---
 tools/lib/traceevent/event-parse.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index d7c37a7d9255..fdcb89be5e67 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -304,7 +304,10 @@ int pevent_register_comm(struct pevent *pevent, const char *comm, int pid)
 	if (!item)
 		return -1;
 
-	item->comm = strdup(comm);
+	if (comm)
+		item->comm = strdup(comm);
+	else
+		item->comm = strdup("<...>");
 	if (!item->comm) {
 		free(item);
 		return -1;
-- 
2.1.4


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/