Re: [PATCH] staging: rts5208: Fixed 80 char & indent warnings

From: Joe Perches
Date: Tue Mar 24 2015 - 10:16:51 EST


On Tue, 2015-03-24 at 11:00 +0300, Dan Carpenter wrote:
> None of these are correct. :(

True. Please run your proposed patches through checkpatch
before sending them.

I think it would be an improvement to rework the flow-hiding
TRACE_RET and TRACE_GOTO macros into two separate lines.

It would also reduce the code size quite a bit if the TRACE
portion of TRACE_RET/TRACE_GOTO was a separate function and
not an inline.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/