Re: [PATCH 2/9] tools lib traceevent: Copy trace_clock and free it

[Steven Rostedt]

On Tue, 24 Mar 2015 12:14:49 -0300
Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:

> Humm, strdup actually sets errno already, from its man page:
> 
> -------------------
> 
> RETURN VALUE
>        On success, the strdup() function returns a pointer to the
> duplicated string.  It returns NULL if insufficient memory was
> available, with errno set to indicate the cause of the error.
> 
> -------------------
> 
> 
> Applying anyway, as this doesn't introduces a problem, right?
> 

Ah, I didn't realize that. I probably should of. The original code just
had a "die()" in it. But I know how much Namhyung loves those ;-)

I removed the die() and noticed that the other removed "die()"s also
set errno = ENOMEM. Those probably could also be removed as they happen
after "remalloc" and such.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/