Re: [PATCH v3 07/10] ntb: drop pci_msi_off call on probe

From: Jiang, Dave
Date: Tue Mar 24 2015 - 12:12:15 EST


On Tue, 2015-03-24 at 16:42 +0100, Michael S. Tsirkin wrote:
> pci core now disables msi on probe automatically,
> drop this from device-specific code.
>
> Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> Cc: linux-pci@xxxxxxxxxxxxxxx
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>

Acked-by: Dave Jiang <dave.jiang@xxxxxxxxx>

> ---
> drivers/ntb/ntb_hw.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c
> index cd29b10..8225cbc 100644
> --- a/drivers/ntb/ntb_hw.c
> +++ b/drivers/ntb/ntb_hw.c
> @@ -1313,8 +1313,6 @@ static int ntb_setup_intx(struct ntb_device *ndev)
> struct pci_dev *pdev = ndev->pdev;
> int rc;
>
> - pci_msi_off(pdev);
> -
> /* Verify intx is enabled */
> pci_intx(pdev, 1);
>
N‹§²æ¸›yú²X¬¶ÇvØ–)Þ{.nlj·¥Š{±‘êX§¶›¡Ü}©ž²ÆzÚj:+v‰¨¾«‘êZ+€Êzf£¢·hšˆ§~†­†Ûÿû®w¥¢¸?™¨è&¢)ßf”ùy§m…á«a¶Úÿ 0¶ìå