Re: [PATCH] usb: gadget: Check for NULL pointer in disconnect

From: Felipe Balbi
Date: Tue Mar 24 2015 - 12:31:14 EST


On Mon, Mar 23, 2015 at 04:00:37PM -0700, Badhri Jagan Sridharan wrote:
> > Do you really see some udc drivers call it after composite_unbind is
> > called? If it is, you may add dump_stack() to track that error.
> >
> > Besides this, function suspended_show is needed to add cdev NULL pointer
> > checking.
>
> We see this happening occasionally in *not yet* upstreamed UDC
> code of some vendors (Yes, disconnect being called after unbind)

fix your UDC. We leave these sort of thing open so people realise they
have to fix their drivers.

--
balbi

Attachment: signature.asc
Description: Digital signature