Re: [PATCH 13/14] kdbus: add walk-through user space example

[David Herrmann]

Hi

On Tue, Mar 24, 2015 at 5:46 PM, Jiri Slaby <jslaby@xxxxxxx> wrote:
> On 03/09/2015, 02:09 PM, Greg Kroah-Hartman wrote:
>> --- /dev/null
>> +++ b/samples/kdbus/Makefile
>> @@ -0,0 +1,10 @@
>> +# kbuild trick to avoid linker error. Can be omitted if a module is built.
>> +obj- := dummy.o
>> +
>> +hostprogs-y += kdbus-workers
>> +
>> +always := $(hostprogs-y)
>
> Errr, no. Not only it causes build failures (even with KDBUS=n), it
> definitely should not be built for everyone.

It's only built if CONFIG_SAMPLES is set, right?

What build-failures does it cause? linux/kdbus.h is not optional based
on CONFIG_KDBUS, so the samples should build just fine. Can you tell
me what kind of errors you get? The kbuild-robots didn't report
anything so far.

> And why is it a host prog? It's a sample prog for the kernel I am
> building, i.e. for the destination arch, like all the other samples.

It's modeled after the other user-space examples in ./samples/, which
all use hostprogs (see samples/{bpf,hidraw,seccomp,uhid}/Makefile). I
have no idea how to build programs that run on the target
architecture. Documentation/kbuild/makefiles.txt doesn't list it,
which is, I guess, the reason why everyone used hostprogs so far. And
given that autotools calls the target architecture "--host", I
actually thought this is what hostprogs does.. apparently that's not
the case, sorry.

Thanks
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/