Re: [RFC PATCH v3 0/8] Provide y2038/y2106 safe rtc_class_ops.set_mmss64()
From: John Stultz
Date: Tue Mar 24 2015 - 17:42:19 EST
On Thu, Mar 19, 2015 at 4:29 PM, Alessandro Zummo <a.zummo@xxxxxxxxxxxx> wrote:
> On Wed, 18 Mar 2015 10:37:26 -0700
> John Stultz <john.stultz@xxxxxxxxxx> wrote:
>
>> On Wed, Jan 28, 2015 at 10:27 AM, Alessandro Zummo <a.zummo@xxxxxxxxxxxx> wrote:
>> > On Thu, 29 Jan 2015 00:12:09 +0800
>> > Xunlei Pang <pang.xunlei@xxxxxxxxxx> wrote:
>> >
>> >> ping Alessandro
>> >
>> > -EBUSY . saw that, looks fine anyhow, but would like to
>> > have a deeper look. we have still some time 'till 2038, right? ;)
>>
>> Hey Alessandro,
>> I was hoping to let these go through you (with your review), but if
>> you're still too busy I can queue them if you'd rather.
>
> Looks fine to me. The only thing that I would change
> is the naming of the drivername_rtc_set_mmss in the drivers:
> it should end with mmss64 when it's changed.
>
> But that's probably just me being pedantic.
>
> Acked-by: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
>
> Can you please queue them?
Thanks for the review! I've queued them in my tree for 4.1
thanks
-john
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/