Re: [PATCH v3 2/9] regmap: Introduce regmap_get_reg_stride.

From: Srinivas Kandagatla
Date: Tue Mar 24 2015 - 19:07:34 EST




On 24/03/15 22:37, Mark Brown wrote:
On Tue, Mar 24, 2015 at 10:30:00PM +0000, Srinivas Kandagatla wrote:

+ /* regmap_get_reg_stride(): Report the register address stride
+ *
+ * Report the register address stride, mainly intended to for use by
+ * generic infrastructure built on top of regmap.
+ */
+int regmap_get_reg_stride(struct regmap *map)

Please fix the indentation for the comment block and add kerneldoc for
the argument. This is an exported function so it should also be /** not
/*

My bad.. I will fix it in next version.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/