Re: [PATCH] Fix braces to GNU style

From: Ingo Molnar
Date: Wed Mar 25 2015 - 04:59:01 EST



* carlossilveirajr@xxxxxxxxx <carlossilveirajr@xxxxxxxxx> wrote:

> From: Carlos Roberto Silveira Junior <carlossilveirajr@xxxxxxxxx>
>
> ---
> kernel/sched/fair.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 7ce18f3..834aa55 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -296,13 +296,12 @@ static inline void list_add_leaf_cfs_rq(struct cfs_rq *cfs_rq)
> * reduces this to two cases.
> */
> if (cfs_rq->tg->parent &&
> - cfs_rq->tg->parent->cfs_rq[cpu_of(rq_of(cfs_rq))]->on_list) {
> + cfs_rq->tg->parent->cfs_rq[cpu_of(rq_of(cfs_rq))]->on_list)
> list_add_rcu(&cfs_rq->leaf_cfs_rq_list,
> &rq_of(cfs_rq)->leaf_cfs_rq_list);
> - } else {
> + else
> list_add_tail_rcu(&cfs_rq->leaf_cfs_rq_list,
> &rq_of(cfs_rq)->leaf_cfs_rq_list);
> - }
>
> cfs_rq->on_list = 1;
> /* We should have no load, but we need to update last_decay. */
> @@ -505,9 +504,9 @@ static void __enqueue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
> * We dont care about collisions. Nodes with
> * the same key stay together.
> */
> - if (entity_before(se, entry)) {
> + if (entity_before(se, entry))
> link = &parent->rb_left;
> - } else {
> + else {
> link = &parent->rb_right;
> leftmost = 0;
> }

But in the kernel we are following the Linux kernel style.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/