Re: [RFC PATCH] kdbus: move all kdbus headers to include/linux/kdbus

[David Herrmann]

Hi

On Wed, Mar 25, 2015 at 4:37 PM, Paul Osmialowski
<p.osmialowsk@xxxxxxxxxxx> wrote:
> These headers are required to implement LSM hooks for kdbus
> and possibly other things that might deal with kdbus.
>
> Signed-off-by: Paul Osmialowski <p.osmialowsk@xxxxxxxxxxx>
> ---
>  include/linux/kdbus/bus.h        | 101 +++++++++++++++
>  include/linux/kdbus/connection.h | 257 +++++++++++++++++++++++++++++++++++++++
>  include/linux/kdbus/domain.h     |  77 ++++++++++++
>  include/linux/kdbus/endpoint.h   |  67 ++++++++++
>  include/linux/kdbus/fs.h         |  28 +++++
>  include/linux/kdbus/handle.h     |  85 +++++++++++++
>  include/linux/kdbus/item.h       |  64 ++++++++++
>  include/linux/kdbus/limits.h     |  64 ++++++++++
>  include/linux/kdbus/match.h      |  35 ++++++
>  include/linux/kdbus/message.h    | 133 ++++++++++++++++++++
>  include/linux/kdbus/metadata.h   |  57 +++++++++
>  include/linux/kdbus/names.h      |  74 +++++++++++
>  include/linux/kdbus/node.h       |  84 +++++++++++++
>  include/linux/kdbus/notify.h     |  30 +++++
>  include/linux/kdbus/policy.h     |  51 ++++++++
>  include/linux/kdbus/pool.h       |  46 +++++++
>  include/linux/kdbus/queue.h      |  92 ++++++++++++++
>  include/linux/kdbus/reply.h      |  68 +++++++++++
>  include/linux/kdbus/util.h       |  74 +++++++++++
>  ipc/kdbus/Makefile               |   2 +
>  ipc/kdbus/bus.h                  | 101 ---------------
>  ipc/kdbus/connection.h           | 257 ---------------------------------------
>  ipc/kdbus/domain.h               |  77 ------------
>  ipc/kdbus/endpoint.h             |  67 ----------
>  ipc/kdbus/fs.h                   |  28 -----
>  ipc/kdbus/handle.h               |  85 -------------
>  ipc/kdbus/item.h                 |  64 ----------
>  ipc/kdbus/limits.h               |  64 ----------
>  ipc/kdbus/match.h                |  35 ------
>  ipc/kdbus/message.h              | 133 --------------------
>  ipc/kdbus/metadata.h             |  57 ---------
>  ipc/kdbus/names.h                |  74 -----------
>  ipc/kdbus/node.h                 |  84 -------------
>  ipc/kdbus/notify.h               |  30 -----
>  ipc/kdbus/policy.h               |  51 --------
>  ipc/kdbus/pool.h                 |  46 -------
>  ipc/kdbus/queue.h                |  92 --------------
>  ipc/kdbus/reply.h                |  68 -----------
>  ipc/kdbus/util.h                 |  74 -----------
>  39 files changed, 1489 insertions(+), 1487 deletions(-)
>  create mode 100644 include/linux/kdbus/bus.h
>  create mode 100644 include/linux/kdbus/connection.h
>  create mode 100644 include/linux/kdbus/domain.h
>  create mode 100644 include/linux/kdbus/endpoint.h
>  create mode 100644 include/linux/kdbus/fs.h
>  create mode 100644 include/linux/kdbus/handle.h
>  create mode 100644 include/linux/kdbus/item.h
>  create mode 100644 include/linux/kdbus/limits.h
>  create mode 100644 include/linux/kdbus/match.h
>  create mode 100644 include/linux/kdbus/message.h
>  create mode 100644 include/linux/kdbus/metadata.h
>  create mode 100644 include/linux/kdbus/names.h
>  create mode 100644 include/linux/kdbus/node.h
>  create mode 100644 include/linux/kdbus/notify.h
>  create mode 100644 include/linux/kdbus/policy.h
>  create mode 100644 include/linux/kdbus/pool.h
>  create mode 100644 include/linux/kdbus/queue.h
>  create mode 100644 include/linux/kdbus/reply.h
>  create mode 100644 include/linux/kdbus/util.h
>  delete mode 100644 ipc/kdbus/bus.h
>  delete mode 100644 ipc/kdbus/connection.h
>  delete mode 100644 ipc/kdbus/domain.h
>  delete mode 100644 ipc/kdbus/endpoint.h
>  delete mode 100644 ipc/kdbus/fs.h
>  delete mode 100644 ipc/kdbus/handle.h
>  delete mode 100644 ipc/kdbus/item.h
>  delete mode 100644 ipc/kdbus/limits.h
>  delete mode 100644 ipc/kdbus/match.h
>  delete mode 100644 ipc/kdbus/message.h
>  delete mode 100644 ipc/kdbus/metadata.h
>  delete mode 100644 ipc/kdbus/names.h
>  delete mode 100644 ipc/kdbus/node.h
>  delete mode 100644 ipc/kdbus/notify.h
>  delete mode 100644 ipc/kdbus/policy.h
>  delete mode 100644 ipc/kdbus/pool.h
>  delete mode 100644 ipc/kdbus/queue.h
>  delete mode 100644 ipc/kdbus/reply.h
>  delete mode 100644 ipc/kdbus/util.h

I'd prefer if we only move the required structure definitions into a
separate header. There is no reason to export all internal entry
points.

Anyway, this is a technicality that actually depends on the
implemented LSM hooks. So I'd prefer if we discuss that in combination
with the actual LSM patches. I'm not entirely sure which parts are
needed. For testing-purposes, we can always use -I./ipc/kdbus/, right?

Thanks
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/