Re: [PATCH] x86/wmi: delete unused wmi_data_lock mutex causing gcc warning

From: Darren Hart
Date: Wed Mar 25 2015 - 13:26:44 EST


On Mon, Mar 23, 2015 at 02:01:37PM -0400, Paul Gortmaker wrote:
> In commit bff431e49ff531a343fbb2b4426e313000844f32 ("ACPI: WMI: Add
> ACPI-WMI mapping driver") this mutex was added, but the rest of the
> final commit never actually made use of it, resulting in:
>
> In file included from include/linux/mutex.h:29:0,
> from include/linux/kernfs.h:13,
> from include/linux/sysfs.h:15,
> from include/linux/kobject.h:21,
> from include/linux/device.h:17,
> from drivers/platform/x86/wmi.c:35:
> drivers/platform/x86/wmi.c:48:21: warning: âwmi_data_lockâ defined but not used [-Wunused-variable]
> static DEFINE_MUTEX(wmi_data_lock);
> ^
>
> A git grep shows no other instances/references to the wmi_data_lock.
> Delete it, assuming that the mutex addition was just a leftover from
> an earlier work in progress version of the change, since the original
> dates from 2008.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>

Queued, thank you Paul.

--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/