Re: [PATCH 3/4] x86/asm/entry/64: use smaller insns

[Andy Lutomirski]

On Wed, Mar 25, 2015 at 10:18 AM, Denys Vlasenko <dvlasenk@xxxxxxxxxx> wrote:
> The $AUDIT_ARCH_X86_64 parameter to syscall_trace_enter_phase1/2
> is a 32-bit constant, loading it with 32-bit MOV produces 5-byte insn
> instead of 10-byte one.

Acked-by: Andy Lutomirski <luto@xxxxxxxxxx>

>
> Signed-off-by: Denys Vlasenko <dvlasenk@xxxxxxxxxx>
> CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> CC: Steven Rostedt <rostedt@xxxxxxxxxxx>
> CC: Ingo Molnar <mingo@xxxxxxxxxx>
> CC: Borislav Petkov <bp@xxxxxxxxx>
> CC: "H. Peter Anvin" <hpa@xxxxxxxxx>
> CC: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
> CC: Oleg Nesterov <oleg@xxxxxxxxxx>
> CC: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> CC: Alexei Starovoitov <ast@xxxxxxxxxxxx>
> CC: Will Drewry <wad@xxxxxxxxxxxx>
> CC: Kees Cook <keescook@xxxxxxxxxxxx>
> CC: x86@xxxxxxxxxx
> CC: linux-kernel@xxxxxxxxxxxxxxx
> ---
>  arch/x86/kernel/entry_64.S | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
> index 11b7339..23aa43e 100644
> --- a/arch/x86/kernel/entry_64.S
> +++ b/arch/x86/kernel/entry_64.S
> @@ -306,7 +306,7 @@ system_call_fastpath:
>         /* Do syscall entry tracing */
>  tracesys:
>         movq %rsp, %rdi
> -       movq $AUDIT_ARCH_X86_64, %rsi
> +       movl $AUDIT_ARCH_X86_64, %esi
>         call syscall_trace_enter_phase1
>         test %rax, %rax
>         jnz tracesys_phase2             /* if needed, run the slow path */
> @@ -317,7 +317,7 @@ tracesys:
>  tracesys_phase2:
>         SAVE_EXTRA_REGS
>         movq %rsp, %rdi
> -       movq $AUDIT_ARCH_X86_64, %rsi
> +       movl $AUDIT_ARCH_X86_64, %esi
>         movq %rax,%rdx
>         call syscall_trace_enter_phase2
>
> --
> 1.8.1.4
>



-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/