Re: [patch 02/12] mm: oom_kill: clean up victim marking and exiting interfaces

From: David Rientjes
Date: Wed Mar 25 2015 - 23:34:49 EST


On Wed, 25 Mar 2015, Johannes Weiner wrote:

> Rename unmark_oom_victim() to exit_oom_victim(). Marking and
> unmarking are related in functionality, but the interface is not
> symmetrical at all: one is an internal OOM killer function used during
> the killing, the other is for an OOM victim to signal its own death on
> exit later on. This has locking implications, see follow-up changes.
>
> While at it, rename mark_tsk_oom_victim() to mark_oom_victim(), which
> is easier on the eye.
>
> Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx>

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>

I like exit_oom_victim() better since it follows the format of other
do_exit() functions.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/