Re: [PATCH] i2c: i2c-mux-gpio: Change log level to debug for probe deferrals

From: Alexander Sverdlin
Date: Thu Mar 26 2015 - 05:10:05 EST


On 25/03/15 18:43, Ioan Nicu wrote:
> Probe deferral is not an error case. It happens only when
> the necessary dependencies are not there yet.
>
> The driver core is already printing a message when a driver
> requests probe deferral, so this can be traced in the logs
> without these error prints.
>
> This patch changes the error messages from these deferral cases
> to debug messages.
>
> Signed-off-by: Ionut Nicu <ioan.nicu.ext@xxxxxxxxx>

Acked-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx>

> ---
> drivers/i2c/muxes/i2c-mux-gpio.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
> index f5798eb..9f1cfca 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -77,7 +77,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
> }
> adapter = of_find_i2c_adapter_by_node(adapter_np);
> if (!adapter) {
> - dev_err(&pdev->dev, "Cannot find parent bus\n");
> + dev_dbg(&pdev->dev, "Cannot find parent bus\n");
> return -EPROBE_DEFER;
> }
> mux->data.parent = i2c_adapter_id(adapter);
> @@ -178,7 +178,7 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev)
>
> parent = i2c_get_adapter(mux->data.parent);
> if (!parent) {
> - dev_err(&pdev->dev, "Parent adapter (%d) not found\n",
> + dev_dbg(&pdev->dev, "Parent adapter (%d) not found\n",
> mux->data.parent);
> return -EPROBE_DEFER;
> }

--
Best regards,
Alexander Sverdlin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/