Re: [PATCH 06/13] ARM: at91: PIT: make IO endian agnostic

[Daniel Lezcano]

On 03/23/2015 12:27 PM, Nicolas Ferre wrote:
> Le 18/03/2015 16:53, Ben Dooks a Ãcrit :
> > Fix the use of __raw IO accessor with the readl/writel_relaxed versions
> > to allow the code to be used on a system running in big endian.
> >
> > Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
> > --
> > CC: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> > CC: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > CC: Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>
> > CC: Linux ARM Kernel <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
> > CC: Andrew Victor <linux@xxxxxxxxxxxx>
> > CC: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
>
> Yes:
> Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
>
> Daniel, do you want to take it?

Yep.

> > CC: Jean-Christophe Plagniol-Villard <plagnioj@xxxxxxxxxxxx>
> > ---
> >   drivers/clocksource/timer-atmel-pit.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c
> > index b5b4d45..c0304ff 100644
> > --- a/drivers/clocksource/timer-atmel-pit.c
> > +++ b/drivers/clocksource/timer-atmel-pit.c
> > @@ -61,12 +61,12 @@ static inline struct pit_data *clkevt_to_pit_data(struct clock_event_device *clk
> >
> >   static inline unsigned int pit_read(void __iomem *base, unsigned int reg_offset)
> >   {
> > -	return __raw_readl(base + reg_offset);
> > +	return readl_relaxed(base + reg_offset);
> >   }
> >
> >   static inline void pit_write(void __iomem *base, unsigned int reg_offset, unsigned long value)
> >   {
> > -	__raw_writel(value, base + reg_offset);
> > +	writel_relaxed(value, base + reg_offset);
> >   }
> >
> >   /*


--
 <http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/