Re: [PATCHv2] pcmcia:Fix memory leak in the function, sa11xx_drv_pcmcia_probe

[Russell King - ARM Linux]

On Thu, Mar 26, 2015 at 07:14:38AM -0400, Nicholas Krause wrote:
> 
> 
> On March 26, 2015 5:52:25 AM EDT, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote:
> >On Wed, Mar 25, 2015 at 11:15:52PM -0400, Nicholas Krause wrote:
> >> This fixes the memory found when running  coccinelle on the latest
> >
> >How does this "fix the memory" ?  Is the memory faulty?
> >
> >> kernel tree for if we are unable to successfully allocate memory
> >> for the structure pointer,sinfo of type skt_dev_info and need to
> >> clean up the memory already allocated to the clk structure pointer,
> >> clk by calling clk_get on it and freeing the no longer required
> >> mermory for this structure pointer.
> >
> >This makes no sense.  clk_get() itself doesn't allocate any memory.  As
> >usual, you act as a mechanical automatom which doesn't understand what
> >you're doing or you just guess.  I don't care which it is, you are a
> >danger to the kernel by doing this.  As many other experienced kernel
> >developers have told you, please stop.
> >
> >In any case, I'm NAKing your patch as there's better ways to solve
> >this.
> >That's where experience and research come in.
> >
> >Nevertheless, thanks for pointing out the oversight, and I notice that
> >there are a few more cases too.
> Very well then I  guess my patch commit message was wrong. 

Again, you fail to understand what you are being told.  Please re-read
the paragraph which starts "In any case, I'm NAKing your patch".

Your patch is one way to solve it, but there are other solutions too.
I've just posted a small patch series which addresses the issue you
have raised.  You need to perform no further action on this.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/