Re: [PATCH 2/3] x86: add a is_e820_ram() helper
From: Ross Zwisler
Date: Thu Mar 26 2015 - 16:53:40 EST
On Thu, 2015-03-26 at 17:43 +0100, Christoph Hellwig wrote:
> On Thu, Mar 26, 2015 at 05:49:38PM +0200, Boaz Harrosh wrote:
> > > +#define E820_PRAM 12
> >
> > Why the PRAM Name. For one 2/3 of this patch say PMEM the Kconfig
> > to enable is _PMEM_, the driver stack that gets loaded is pmem,
> > so PRAM is unexpected.
> >
> > Also I do believe PRAM is not the correct name. Yes NvDIMMs are RAM,
> > but there are other not RAM technologies that can be supported exactly
> > the same way.
> > MEM is a more general name meaning "on the memory bus". I think.
> >
> > I would love the consistency.
>
> Ingo asked for the PRAM name, I don't really care either way.
I also prefer "E820_PMEM", fwiw.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/