Re: [PATCH v2 2/2] Staging: slicoss: Get rid of redundant pointer variable

[Greg KH]

On Thu, Mar 26, 2015 at 01:52:33PM -0700, Joe Perches wrote:
> On Thu, 2015-03-26 at 19:52 +0100, Greg KH wrote:
> > On Thu, Mar 26, 2015 at 11:52:43PM +0530, Niranjan Dighe wrote:
> > > Replace string directly in place of format string and remove pointer
> > > variable which was used just once.
> []
> > > diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> []
> > > @@ -3046,7 +3045,8 @@ static int slic_entry_probe(struct pci_dev *pcidev,
> > >  		return err;
> > >  
> > >  	if (did_version++ == 0) {
> > > -		dev_info(&pcidev->dev, "%s\n", slic_banner);
> > > +		dev_info(&pcidev->dev,
> > > +		"Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)\n");
> > 
> > Why make this change?  What's wrong with the original code?
> > 
> > There is the issue that driver should be quiet, so really, you can just
> > delete all of this nonsense, but that's a different issue here...
> 
> You could also use dev_info_once instead.

No, drivers shouldn't make any noise when loaded, or when bound to a
device, that's just fluff that is not needed, and is why we made the
default module load macros to help prevent that from happening.  Looks
like people really wanted to be chatty here and tried to do it in their
probe function instead :(

Just delete it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/