Re: [PATCH v7 0/5] vfs: Non-blockling buffered fs read (page cache only)

From: Christoph Hellwig
Date: Fri Mar 27 2015 - 04:18:32 EST


On Thu, Mar 26, 2015 at 08:28:24PM -0700, Andrew Morton wrote:
> I still don't understand why pwritev() exists. We discussed this last
> time but it seems nothing has changed. I'm not seeing here an adequate
> description of why it exists nor a justification for its addition.

pwritev2? I have patches to support per-I/O O_DSYNC with it, lots of
folks including Samba and SCSI targets want this because their protocols
support it. The patches were posted with earlier versions of Miklos
series.

It's cleaner to add the two system calls in go when we plan using them
anyway and have symmetric infrastructure, and I did not hear any
disagreement with that on LSF. Did you skip this session?

> And (again) we've discussed this before, but the patchset gets resent
> as if nothing had happened.

We had long discussiosn about it both here and at LSF. We had everyone
agree and nod there, and only your repeated argument here, so maybe it's
not Miklos who is disonnected but you?

Also that whole fincore argument is rather hypothetic - it's only been
pushed in to ugly to live multiplexers that also expose things like
pfns, while with preadv2 we have a trivial and easy to use API read to
merge, and various consumerms just waiting for it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/