Re: [PATCH 4/4] x86/asm/entry/32: Use PUSH instructions to build pt_regs on stack

[Ingo Molnar]

* Denys Vlasenko <dvlasenk@xxxxxxxxxx> wrote:

> On 03/27/2015 12:32 PM, Ingo Molnar wrote:
> > 
> > * Denys Vlasenko <dvlasenk@xxxxxxxxxx> wrote:
> > 
> >> This mimics the recent similar 64-bit change.
> >> Saves ~110 bytes of code.
> > 
> > Would be nice to know whether you tested all the affected system entry 
> > variants, on both AMD and Intel CPUs?
> 
> Yes, I did. I also looked at the diff of entry_64.o disassembly, to have
> a different view of the changes.

That kind of information needs to be in the changelog.

> I know how fragile this stuff is.

yeah ...

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/