Re: [PATCH] i2c: davinci: fixup wait_for_completion_timeout handling

From: Wolfram Sang
Date: Fri Mar 27 2015 - 11:50:10 EST


On Tue, Mar 17, 2015 at 03:51:13AM -0400, Nicholas Mc Guire wrote:
> wait_for_completion_timeout return 0 (timeout) or >=1 (completion) so the check
> for >= 0 is always true and can be dropped implying that r==-EREMOTEIO and thus
> the return of -EREMOTEIO can be done in the if (dev->buf_len) branch.
> As wait_for_completion_timeout returns unsigned long not int, and int r is
> exclusively used for wait_for_completion_timeout it is renamed and the type
> changed to unsigned long.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>

Applied to for-next, thanks!

Attachment: signature.asc
Description: Digital signature