Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

[Yun Wang]

On Fri, Mar 27, 2015 at 6:16 PM, ira.weiny <ira.weiny@xxxxxxxxx> wrote:
> On Fri, Mar 27, 2015 at 10:13:19AM -0600, Jason Gunthorpe wrote:
>> On Fri, Mar 27, 2015 at 04:47:36PM +0100, Michael Wang wrote:
>> >
>> > Introduce helper has_iwarp() to help us check if an IB device
>> > support IWARP protocol.
>>
>> Should probably be !has_rdma_read_sges()
>>
>> True if the device can handle more than one SGE entry on a RDMA READ
>> work request.
>
> Isn't this value already provided by the query_device verb?
>
> The verbs spec states the Query HCA contains the:
>
> "Maximum number of scatter/gather entries per Work Request supported by the
> HCA."

I'm not sure but may be query_device() is just too expensive for this path?
I need some investigation here too.

Regards,
Michael Wang

>
> -- Ira
>
>>
>> Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/