Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

[Pali RohÃr]

On Saturday 28 March 2015 04:43:35 Dmitry Torokhov wrote:
> On Sat, Mar 28, 2015 at 01:30:58AM +0000, Santiago Gala wrote:
> > The behaviour is the same with 3.19.1 as with 4.0.0-rc5 +
> > the patched psmouse you give me. The difference in lsinput
> > is just name and current position:
> > 
> > $ diff -u alps06.txt alps11-new.txt
> > --- alps06.txt  2015-03-18 07:21:08.827315595 +0100
> > +++ alps11-new.txt      2015-03-27 21:24:44.285503438 +0100
> > @@ -1,5 +1,5 @@
> > 
> >  # EVEMU 1.2
> > 
> > -# Input device name: "AlpsPS/2 ALPS DualPoint TouchPad"
> > +# Input device name: "AlpsPS/2 ALPS GlidePoint"
> > 
> >  # Input device ID: bus 0x11 vendor 0x02 product 0x08
> >  version 0x700 # Supported events:
> >  #   Event type 0 (EV_SYN)
> > 
> > @@ -15,14 +15,14 @@
> > 
> >  #     Event code 335 (BTN_TOOL_QUADTAP)
> >  #   Event type 3 (EV_ABS)
> >  #     Event code 0 (ABS_X)
> > 
> > -#       Value   1076
> > +#       Value   1549
> > 
> >  #       Min        0
> >  #       Max     4095
> >  #       Fuzz       0
> >  #       Flat       0
> >  #       Resolution 42
> >  #     Event code 1 (ABS_Y)
> > 
> > -#       Value    869
> > +#       Value    877
> > 
> >  #       Min        0
> >  #       Max     2047
> >  #       Fuzz       0
> > 
> > @@ -59,7 +59,7 @@
> > 
> >  # Properties:
> >  #   Property  type 0 (INPUT_PROP_POINTER)
> >  #   Property  type 2 (INPUT_PROP_BUTTONPAD)
> > 
> > -N: AlpsPS/2 ALPS DualPoint TouchPad
> > +N: AlpsPS/2 ALPS GlidePoint
> > 
> >  I: 0011 0002 0008 0700
> >  P: 05 00 00 00 00 00 00 00
> >  B: 00 0b 00 00 00 00 00 00 00
> 
> Hmm, if resolution is the same I wonder if we are dropping
> some packets... Is there any messages from psmouse module in
> dmesg?
> 
> Thanks.
> 

For me output/diff looks ok. Name is based on DUALPOINT flag 
which is cleared for non trackstick device version. And my patch 
adding that trackstick detection for v7.

-- 
Pali RohÃr
pali.rohar@xxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part.