Re: [PATCH 05/86] x86/gart: use uapi/linux/pci_ids.h directly

From: Ingo Molnar
Date: Mon Mar 30 2015 - 01:29:55 EST



* Michael S. Tsirkin <mst@xxxxxxxxxx> wrote:

> Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h,
> use the new header directly so we can drop
> the wrapper in include/linux/pci_ids.h.
>
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> ---
> arch/x86/kernel/aperture_64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c
> index 76164e1..3b52a56 100644
> --- a/arch/x86/kernel/aperture_64.c
> +++ b/arch/x86/kernel/aperture_64.c
> @@ -17,7 +17,7 @@
> #include <linux/init.h>
> #include <linux/memblock.h>
> #include <linux/mmzone.h>
> -#include <linux/pci_ids.h>
> +#include <uapi/linux/pci_ids.h>
> #include <linux/pci.h>
> #include <linux/bitops.h>
> #include <linux/suspend.h>
> --
> MST
>

NAK, it's absolutely ridiculous to send a 86 patches series for a
trivial change like this!

Just do the rename in a single patch and avoid the churn. Even if
there are conflicts, they are utmost trivial to fix up.

In fact the usual way to do such renames is to wait until the end of
-rc1, auto-generate it and send Linus the core patch with the trivial
renames straight away.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/