Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

From: Michael S. Tsirkin
Date: Mon Mar 30 2015 - 02:52:31 EST


On Sun, Mar 29, 2015 at 10:59:45AM -0700, Joe Perches wrote:
> On Sun, 2015-03-29 at 15:36 +0200, Michael S. Tsirkin wrote:
> > The macros in pci_ids.h are pretty useful for userspace
> > using the pci sysfs interface, e.g. to decode class
> > device and vendor sysfs files.
> >
> > At the moment userspace is forced to duplicate these macros (e.g. QEMU does
> > this, so does gpxe, seabios, etc), it is better to export them in
> > /usr/include/linux/pci_ids.h so everyone can just include this header.
> >
> > This patchset is structured as follows:
> > 1. include/linux/pci_ids.h is moved to include/uapi/linux/pci_ids.h;
> > a stub file is created in include/linux/pci_ids.h to avoid breaking
> > bisect
> > 2. all users are converted to use the new header
> > 3. include/linux/pci_ids.h is removed
> > 4. cleanups for several issues detected during step 2
> >
> > The patchset was built on several architectures (mips/ppc/x86),
> > boot-tested on x86 only - build seems sufficient for this kind of
> > change.
> >
> > I think the pci tree is the most appropriate for this patchset.
> > Please review it, and consider for 4.1.
>
> Hello again Michael.
>
> It's nicer if you send this cover letter to all mailing lists
> that receive any of the individual patches so that people can
> reply to the 0/n patch and a single discussion thread can
> happen for generic issues for the entire patchset.
>
> It'd be even nicer to cc all of the maintainers of any of the
> sections modified, but vger mailing lists reject any email
> with more than 2k of email headers. Unfortunately, patchsets
> for multiple subsystems create long cc lists that generally
> exceed this limit.

Exactly. That's also why I had to split the patchset -
at least the individual patches are Cc'd fully then.

--
MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/