Re: [PATCH 01/86] pci: export pci_ids.h

From: Michael S. Tsirkin
Date: Mon Mar 30 2015 - 07:42:06 EST


On Mon, Mar 30, 2015 at 01:35:16PM +0200, Greg KH wrote:
> On Mon, Mar 30, 2015 at 01:19:14PM +0200, Michael S. Tsirkin wrote:
> > Why there much more that two packages, I can find
> > at least 5 copies in the wild. Why? I think it's because it's part of
> > linux ABI that doesn't have matching headers. People are asked to build
> > their own, so of course they copy each other.
> >
> > Once linux exports these headers everyone can stop
> > duplicating each other and others, and just use linux headers too.
>
> As I'm not the PCI maintainer anymore, I'll let Bjorn decide about this.
>
> But, your original patch series isn't ok, we don't want to export the
> pci vendor/device ids to userspace, that isn't the job of the kernel to
> do so. If we should be exporting the pci class and config structures or
> not is Bjorn's decision.
>
> greg k-h


I sent v2 doing exactly that.
Thanks a lot for the review.

--
MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/