Re: [PATCH] genirq: provide dummy set_irq_wake()

[Felipe Balbi]

On Mon, Mar 30, 2015 at 01:06:24PM -0500, Felipe Balbi wrote:
> On Mon, Mar 30, 2015 at 04:15:45PM +0300, Roger Quadros wrote:
> > Without this system suspend is broken on systems that have
> > drivers calling enable/disable_irq_wake() for interrupts based off
> > the dummy irq hook.
> > (e.g. drivers/gpio/gpio-pcf857x.c)
> > 
> > http://article.gmane.org/gmane.linux.kernel/1879035
> > 
> > Signed-off-by: Roger Quadros <rogerq@xxxxxx>
> > ---
> >  kernel/irq/dummychip.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/kernel/irq/dummychip.c b/kernel/irq/dummychip.c
> > index 988dc58..2405d7a 100644
> > --- a/kernel/irq/dummychip.c
> > +++ b/kernel/irq/dummychip.c
> > @@ -32,6 +32,11 @@ static unsigned int noop_ret(struct irq_data *data)
> >  	return 0;
> >  }
> >  
> > +static int noop_int_ret(struct irq_data *data, unsigned int val)
> > +{
> > +	return 0;
> > +}
> > +
> 
> isn't this the same as noop_ret ?

oh no, unsigned versus signed.

-- 
balbi

Attachment: signature.asc
Description: Digital signature