Re: [PATCH] perf, record: Add clockid parameter

[David Ahern]

On 3/30/15 1:32 PM, Peter Zijlstra wrote:

> > > --- a/tools/perf/builtin-record.c
> > > +++ b/tools/perf/builtin-record.c
> > > @@ -732,13 +732,16 @@ static const struct clockid_map clockids
> > >   	/* available for all events, NMI safe */
> > >   	CLOCKID_MAP("monotonic", CLOCK_MONOTONIC),
> > >   	CLOCKID_MAP("monotonic_raw", CLOCK_MONOTONIC_RAW),
> > > -	CLOCKID_MAP("raw", CLOCK_MONOTONIC_RAW),
> > >
> > >   	/* available for some events */
> > >   	CLOCKID_MAP("realtime", CLOCK_REALTIME),
> > >   	CLOCKID_MAP("boottime", CLOCK_BOOTTIME),
> > >   	CLOCKID_MAP("tai", CLOCK_TAI),
> > >
> > > +	/* available for the lazy */
> > > +	CLOCKID_MAP("mono", CLOCK_MONOTONIC),
> > > +	CLOCKID_MAP("raw", CLOCK_MONOTONIC_RAW),
> > > +
> >
> > how about this one as well:
> > CLOCKID_MAP("real", CLOCK_REALTIME),
>
> CLOCK_REALTIME is of limited usability because its not NMI safe.

sure, but you have the long version above. I was also suggesting the 
shortcut version -- 5 fewer letters.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/