Re: [PATCH 1/3] timer: Allocate per-cpu tvec_base's statically

[Viresh Kumar]

On 31 March 2015 at 13:15, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
> * Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>
>> From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>

>> +             if (!boot_done) {
>> +                     boot_done = 1; /* skip the boot cpu */
>
> So it would be a lot more descriptive to name this flag
> 'boot_cpu_skipped'?

Yes.

> Also, I'd put a description about the PER_CPU background into comments
> as well, because it's not obvious at first sight at all what the whole
> (boot_tvec_bases, tvec_bases, __tvec_bases) dance does.

Yeah, so I did that with a one liner in the last patch, but that doesn't
look good enough. I will try to do something better in V2.

Thanks for your reviews.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/