Re: [PATCH 05/12] HID: hid-lg4ff: Update a warning message for a case where device is incorrectly flagged to be handled by hid-lg4ff in hid-lg.

[Jiri Kosina]

On Sat, 21 Mar 2015, Michal Malà wrote:

> The original warning message was highly misleading. This warning can be
> triggered only if a device is flagged to be handled by hid-lg4ff in
> hid-lg but hid-lg4ff lacks support for such device.
> 
> Signed-off-by: Michal Malà <madcatxster@xxxxxxxxxxxxxxxxxx>
> ---
>  drivers/hid/hid-lg4ff.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
> index d1d5d45..a2f47ee 100644
> --- a/drivers/hid/hid-lg4ff.c
> +++ b/drivers/hid/hid-lg4ff.c
> @@ -1021,8 +1021,7 @@ int lg4ff_init(struct hid_device *hid)
>  	}
>  
>  	if (i == ARRAY_SIZE(lg4ff_devices)) {
> -		hid_err(hid, "Device is not supported by lg4ff driver. If you think it should be, consider reporting a bug to"
> -			     "LKML, Simon Wood <simon@xxxxxxxxxxxxx> or Michal Maly <madcatxster@xxxxxxxxx>\n");
> +		hid_err(hid, "This device is flagged to be handled by the lg4ff module but this module does not know how to handle it. Please report this as a bug to LKML, Simon Wood <simon@xxxxxxxxxxxxx> or Michal Maly <madcatxster@xxxxxxxxxxxxxxxxxx>\n");

Could you please split this so that we don't have this ugly overly long 
line, and resend this patch as v2? Thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/